Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jobs implementation in k8s infra monitoring #6629

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amlannandy
Copy link
Member

@amlannandy amlannandy commented Dec 13, 2024

Summary

implements jobs entity in infra monitoring

  • jobs list table
  • jobs detail view

Related Issues / PR's

N/A

Screenshots

Screenshot 2025-01-14 at 10 59 13 PM

Affected Areas and Manually Tested Areas

Infra Monitoring section


Important

Implements Kubernetes jobs monitoring in infrastructure monitoring with job listing, detailed views, and support for events, logs, metrics, and traces.

  • Behavior:
    • Implements Kubernetes jobs monitoring in infrastructure monitoring.
    • Adds K8sJobsList component for listing jobs with filtering and sorting.
    • Adds JobDetails component for detailed job view with tabs for metrics, logs, traces, and events.
    • Supports pagination and filtering for job events and logs.
  • API:
    • Adds getK8sJobsList function in getK8sJobsList.ts to fetch job data.
    • Introduces useGetK8sJobsList hook for querying job data.
  • UI Components:
    • Adds JobEvents, JobLogs, JobMetrics, and JobTraces components for detailed job views.
    • Updates InfraMonitoringK8s.tsx to include jobs in the monitoring categories.
  • Styles:
    • Adds styles for job components in JobEvents.styles.scss, JobLogs.styles.scss, JobMetrics.styles.scss, and JobTraces.styles.scss.

This description was created by Ellipsis for 152b1b9. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Dec 13, 2024
@amlannandy amlannandy force-pushed the feat/infra-monitoring-k8s-nodes branch 5 times, most recently from b5d57e1 to ba944d0 Compare December 24, 2024 06:53
@amlannandy amlannandy force-pushed the feat/infra-monitoring-k8s-nodes branch from 186f768 to 6d441f3 Compare December 27, 2024 04:04
Base automatically changed from feat/infra-monitoring-k8s-nodes to feat/infra-monitoring-k8s January 3, 2025 06:09
@amlannandy amlannandy force-pushed the feat/infra-monitoring-k8s branch from c89ffab to 79cae2d Compare January 3, 2025 06:14
@YounixM YounixM force-pushed the feat/infra-monitoring-k8s branch from a294614 to 6855009 Compare January 6, 2025 05:56
@amlannandy amlannandy force-pushed the feat/infra-monitoring-k8s branch from 2edb730 to 579c7cb Compare January 8, 2025 05:21
@YounixM YounixM force-pushed the feat/infra-monitoring-k8s branch from 579c7cb to 22a33e3 Compare January 8, 2025 10:32
Base automatically changed from feat/infra-monitoring-k8s to main January 8, 2025 10:43
@amlannandy amlannandy force-pushed the feat/infra-monitoring-k8s-jobs branch from a9011ac to 152b1b9 Compare January 14, 2025 17:28
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@amlannandy amlannandy changed the title feat: implement jobs list table for infra monitoring feat: jobs implementation in k8s infra monitoring Jan 14, 2025
@amlannandy amlannandy marked this pull request as ready for review January 14, 2025 17:30
@amlannandy amlannandy requested a review from YounixM as a code owner January 14, 2025 17:30
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 152b1b9 in 2 minutes and 7 seconds

More details
  • Looked at 4611 lines of code in 33 files
  • Skipped 0 files when reviewing.
  • Skipped posting 9 drafted comments based on config settings.
1. frontend/src/api/infraMonitoring/getK8sJobsList.ts:70
  • Draft comment:
    Consider adding more robust error handling for network errors or unexpected responses to improve reliability.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The function getK8sJobsList is used to fetch data, but the error handling is not robust. It should handle network errors or unexpected responses more gracefully.
2. frontend/src/container/InfraMonitoringK8s/Jobs/K8sJobsList.tsx:301
  • Draft comment:
    Consider defining expandedRowRender outside the component or using useCallback to prevent unnecessary re-renders.
  • Reason this comment was not posted:
    Confidence changes required: 40%
    The expandedRowRender function is defined within the K8sJobsList component, which could lead to unnecessary re-renders. It would be better to define it outside the component or use useCallback to memoize it.
3. frontend/src/container/InfraMonitoringK8s/Jobs/K8sJobsList.tsx:222
  • Draft comment:
    Ensure setCurrentPage and setOrderBy are included in the dependency array of useCallback for handleTableChange.
  • Reason this comment was not posted:
    Confidence changes required: 30%
    The handleTableChange function is defined using useCallback, which is good for performance. However, it should include setCurrentPage and setOrderBy in its dependency array to ensure it always has the latest references.
4. frontend/src/container/InfraMonitoringK8s/Jobs/K8sJobsList.tsx:397
  • Draft comment:
    Include setGroupBy and setExpandedRowKeys in the dependency array of useCallback for handleGroupByChange.
  • Reason this comment was not posted:
    Confidence changes required: 30%
    The handleGroupByChange function uses useCallback but does not include setGroupBy and setExpandedRowKeys in its dependency array. This could lead to stale closures.
5. frontend/src/container/InfraMonitoringK8s/Jobs/JobDetails/Logs/JobLogsDetailedView.tsx:66
  • Draft comment:
    Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
6. frontend/src/container/InfraMonitoringK8s/Jobs/JobDetails/Metrics/JobMetrics.tsx:100
  • Draft comment:
    Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.
7. frontend/src/container/InfraMonitoringK8s/Jobs/JobDetails/Traces/JobTraces.tsx:165
  • Draft comment:
    Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.
8. frontend/src/container/InfraMonitoringK8s/Jobs/K8sJobsList.tsx:304
  • Draft comment:
    Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.
9. frontend/src/container/InfraMonitoringK8s/Jobs/utils.tsx:274
  • Draft comment:
    Avoid using inline styles. Use external stylesheets or styled components instead. This applies to other instances in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_FuMuXRAIAnmIM4cN


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs required enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant